fix(helpdesk): translate dashboard labels + KPI widget titles#11
Merged
Conversation
Business-user testing in a zh-CN locale showed the helpdesk dashboards
half-localized: object/field labels were Chinese, but the dashboard titles,
KPI widget titles, and the dashboard nav entries stayed English ("Agent
Workbench", "My Open Tickets", "SLA Breaching", …).
Root cause: the translation bundles only populated `objects` and `apps`.
`TranslationData` also supports a `dashboards` section
(`dashboards.<name>.{label,widgets.<key>.title}`) — it was simply unused.
Add `dashboards` translations for agent_workbench_dashboard and
manager_overview_dashboard to both en and zh-CN. Verified end-to-end in the
composed `all` environment: the dashboard now renders fully Chinese
(客服工作台 / 我的待处理工单 / SLA 即将超时 / 不满客户 / 待分类 …).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during business-user testing (zh-CN)
The helpdesk dashboards rendered half-localized: object/field labels were Chinese, but dashboard titles, KPI widget titles, and dashboard nav entries stayed English.
Root cause: the translation bundles only populated
objectsandapps.TranslationDataalso supports adashboardssection (dashboards.<name>.{label, widgets.<key>.title}) — it was simply unused.Fix
Add
dashboardstranslations foragent_workbench_dashboardandmanager_overview_dashboardto bothen.tsandzh-CN.ts.Verified end-to-end
Booted in the composed
allenvironment and confirmed in the browser — the dashboard now renders fully Chinese:pnpm --filter @objectlab/helpdesk typecheckpasses.🤖 Generated with Claude Code